Refactor resource helper to correctly get resource URLs when building in Xcode #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify ResourceHelper
…code project version Also updated (fixed the broken) resource files references in Xcode project.
|
Should fix #130 |
DivineDominion
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
LGTM, thank you for the fix and for championing this change!
I've opened #133 to make the robots think of issues like this 🤖
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps
swift-tools-versionfrom 5.0 to 5.5 which allows SPM bundle resources.Moves Test sample CSV files to their own directory.
Changes tests to fail instead of crash if test data file cannot be loaded.
Updates
ResourceHelperto better handle finding URLs of test resource files either from SPM or from the Xcode project.